Restrict list comprehension complexity#30
Merged
Conversation
13 tasks
cfournie
force-pushed
the
list_comprehensions
branch
from
83763aa to
01164a2
Compare
JasonMWhite
reviewed
Mar 14, 2017
shopify_python/google_styleguide.py
Outdated
| 'finally-too-long', | ||
| "The larger the 'finally' body size, the more likely that an exception will be raised during " | ||
| "resource cleanup activities."), | ||
| 'C6010': ('Multiple generators in list comprehension', |
There was a problem hiding this comment.
Only one of us can use this code :)
JasonMWhite
approved these changes
Mar 14, 2017
JasonMWhite
left a comment
JasonMWhite
left a comment
There was a problem hiding this comment.
Other than potentially conflicting on code C6010
cfournie
force-pushed
the
list_comprehensions
branch
2 times, most recently
from
2b3a1a9 to
34a77f3
Compare
cfournie
force-pushed
the
list_comprehensions
branch
from
34a77f3 to
6ab4d2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Complicated list comprehensions or generator expressions can be hard to read." To encourage simple list comprehensions let's limit them to using one
forstatement each.